Link to log diff between repost in "To upstream" badge #264
Conversation
krzema12
changed the title
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'SnakeKMP benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 1a4aa28 | Previous: abe514a | Ratio |
|---|---|---|---|
macosX64.LoadingTimeBenchmark.loadsOpenAiSchema ( {"openAiYamlPath":"data/issues/kmp-issue-204-OpenAI-API.yaml"} ) |
215.2954947392857 ms/op |
121.74859682558142 ms/op |
1.77 |
This comment was automatically generated by workflow using github-action-benchmark.
What do you think about excluding macosX64 from benchmarks? It is a bit flaky in the last couple of months (in my repo as well) |
I'm fine with this, we have enough coverage for other platforms and these benchmarks should catch regressions. Do you have a moment to take care of it? 🙏 |
| UPSTREAM_COMMIT=$(cat ../upstream-commit.txt) | ||
| echo "See in BitBucket: https://bitbucket.org/snakeyaml/snakeyaml-engine/branches/compare/master..${'$'}UPSTREAM_COMMIT" > ../$logDiffBetweenRepos | ||
| echo "" >> ../$logDiffBetweenRepos | ||
| git log --oneline ${'$'}UPSTREAM_COMMIT..master >> ../$logDiffBetweenRepos |
There was a problem hiding this comment.
suggestion: maybe introduce a shell variable with the command to avoid duplication?
There was a problem hiding this comment.
I tried, but the new lines disappear when writing git's output stored in a variable to a text file. For sure there's a way to make it work, but I just think we can go with this minor duplication, unless you know from the top of your head how to fight this Bash peculiarity? 😁
There was a problem hiding this comment.
No, I don't unfortunately)
But I meant that you could extract the command itself into a variable and execute it like sh -c $command or eval $command (for bash)
Part of #260.
Thanks to this, we can preview what commits need to be synced.