Remove irrelevant JavaDoc #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vampire
force-pushed
the
remove-irrelevant-javadoc
branch
from
66042b5 to
db885f9
Compare
Strings are never UTF-8 encoded. Strings are a sequence of Unicode characters. If these Unicode characters are encoded into a sequence of bytes or decoded from a sequence of bytes, then encodings like UTF-8 come into play. Same for BOM, they are just not relevant when we talk about Strings or Readers, they are only relevant if starting a stream of bytes, otherwise they are just content.
Vampire
force-pushed
the
remove-irrelevant-javadoc
branch
from
db885f9 to
727b81e
Compare
|
It makes perfect sense to me when you explain it this way, but on the other hand I recall we had some encoding-related issues/changes - @aSemy can you weigh in if the adjustments make sense to you as well (just docs, but good to have common understanding here)? |
krzema12
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strings are never UTF-8 encoded.
Strings are a sequence of Unicode characters.
If these Unicode characters are encoded into a sequence of bytes
or decoded from a sequence of bytes, then encodings like UTF-8 come into play.
Same for BOM, they are just not relevant when we talk about Strings or Readers,
they are only relevant if starting a stream of bytes, otherwise they are just content.