Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kotlin 2.0.0 #187

Merged
merged 3 commits into from
May 24, 2024
Merged

Kotlin 2.0.0 #187

merged 3 commits into from
May 24, 2024

Conversation

aSemy
Copy link
Collaborator

@aSemy aSemy commented May 17, 2024 •
edited
Loading

  • remove KT-51379 workaround
  • add .kotlin/ to .gitignore
  • Disable Yarn (K2 can use NPM instead - disabling Yarn is nice because it's one less tool to worry about)

@aSemy aSemy self-assigned this May 17, 2024
@aSemy
Kotlin 2.0.0-RC3
40ed799 
- remove KT-51379 workaround
- add `.kotlin/` to `.gitignore`
- update `yarn.lock`
@aSemy
Copy link
Collaborator Author

aSemy commented May 17, 2024

I've experimented briefly, but I think IntelliJ doesn't support K2 very well. I kept seeing IDE errors about kotlin.Unit not being found.

@aSemy aSemy changed the title Kotlin 2.0.0-RC3 Kotlin 2.0.0 May 22, 2024
@aSemy aSemy marked this pull request as ready for review May 22, 2024 20:04
@krzema12
Copy link
Owner

krzema12 commented May 23, 2024 •
edited
Loading

I've experimented briefly, but I think IntelliJ doesn't support K2 very well. I kept seeing IDE errors about kotlin.Unit not being found.

Do you know if this issue is tracked somewhere? As you spend more time in the code base, so you find it a blocker for merging this PR? I use Kotlin 2.0 in github-workflows-kt and haven't noticed this problem.

@aSemy
Copy link
Collaborator Author

aSemy commented May 24, 2024

Do you know if this issue is tracked somewhere? As you spend more time in the code base, so you find it a blocker for merging this PR? I use Kotlin 2.0 in github-workflows-kt and haven't noticed this problem.

So K2 works - but IntelliJ's K2 mode doesn't work for KMP projects https://blog.jetbrains.com/idea/2024/03/k2-kotlin-mode-alpha-in-intellij-idea/. So, just don't enable K2 in IntelliJ for now. I couldn't find a YouTrack issue...

@aSemy aSemy merged commit 241ce26 into main May 24, 2024
4 checks passed
@aSemy aSemy deleted the feat/k2 branch May 24, 2024 08:18
aSemy added a commit that referenced this pull request May 24, 2024
@aSemy
Add NPM package-lock.json
2e834ec 
The Yarn package lock file was removed in #187,
but I didn't add the new NPM `package-lock.json`, but it is required.

Re-add the 'relocate lockfile dir' logic.

Enable reportNewPackageLock so KGP creates an error if the lockfile is missing (otherwise it generates a new one and doesn't complain, which obscures the fact that one is missing!)
@aSemy aSemy mentioned this pull request May 24, 2024
Merged
aSemy added a commit that referenced this pull request May 24, 2024
@aSemy
Add NPM package-lock.json
0969b8f 
The Yarn package lock file was removed in #187,
but I didn't add the new NPM `package-lock.json`, but it is required.

Re-add the 'relocate lockfile dir' logic.

Enable reportNewPackageLock so KGP creates an error if the lockfile is missing (otherwise it generates a new one and doesn't complain, which obscures the fact that one is missing!)
@aSemy
Copy link
Collaborator Author

aSemy commented May 24, 2024 •
edited
Loading

Here's the ticket for K2 KMP support in IJ https://youtrack.jetbrains.com/issue/KTIJP-6

krzema12 pushed a commit that referenced this pull request May 24, 2024
@aSemy
Add NPM package-lock.json (#192)
c3c5034 
The Yarn package lock file was removed in
#187, but I didn't
add the new NPM `package-lock.json`, but it is required.

- Re-add the 'relocate lockfile dir' logic.
- Enable reportNewPackageLock so KGP creates an error if the lockfile is
missing (otherwise it generates a new one and doesn't complain, which
obscures the fact that one is missing!)
- Add workaround for https://youtrack.jetbrains.com/issue/KT-67442
krzema12 referenced this pull request in typesafegithub/github-workflows-kt Jun 8, 2024
@renovate @krzema12
fix(deps): update dependency it.krzeminski:snakeyaml-engine-kmp to v3 (…
39c6956 
…#1475)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[it.krzeminski:snakeyaml-engine-kmp](https://github.com/krzema12/snakeyaml-engine-kmp)
| `2.7.5` -> `3.0.0` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/it.krzeminski:snakeyaml-engine-kmp/3.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/it.krzeminski:snakeyaml-engine-kmp/3.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/it.krzeminski:snakeyaml-engine-kmp/2.7.5/3.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/it.krzeminski:snakeyaml-engine-kmp/2.7.5/3.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>krzema12/snakeyaml-engine-kmp
(it.krzeminski:snakeyaml-engine-kmp)</summary>

###
[`v3.0.0`](https://github.com/krzema12/snakeyaml-engine-kmp/releases/tag/v3.0.0)

### TODO: refine the release notes to enumerate breaking changes

#### 💣 Breaking changes

- change package from `org.snakeyaml.engine.v2` to
`it.krzeminski.snakeyaml.engine.kmp` by
[@&#8203;aSemy](https://github.com/aSemy) in
[https://github.com/krzema12/snakeyaml-engine-kmp/pull/158](https://github.com/krzema12/snakeyaml-engine-kmp/pull/158)
-   TODO: add more

#### 🌟 Features

- Add wasmJs target by [@&#8203;krzema12](https://github.com/krzema12)
in
[https://github.com/krzema12/snakeyaml-engine-kmp/pull/191](https://github.com/krzema12/snakeyaml-engine-kmp/pull/191)

#### Other changes

- Update dependency org.jetbrains.kotlin:kotlin-gradle-plugin to v1.9.24
by [@&#8203;renovate](https://github.com/renovate) in
[https://github.com/krzema12/snakeyaml-engine-kmp/pull/162](https://github.com/krzema12/snakeyaml-engine-kmp/pull/162)
- Emitter: Add message for Unexpected Event.ID error by
[@&#8203;aSemy](https://github.com/aSemy) in
[https://github.com/krzema12/snakeyaml-engine-kmp/pull/170](https://github.com/krzema12/snakeyaml-engine-kmp/pull/170)
- Fix scanning for tabs in plain-spaces by
[@&#8203;aSemy](https://github.com/aSemy) in
[https://github.com/krzema12/snakeyaml-engine-kmp/pull/173](https://github.com/krzema12/snakeyaml-engine-kmp/pull/173)
- Refactor StandardConstructor by
[@&#8203;aSemy](https://github.com/aSemy) in
[https://github.com/krzema12/snakeyaml-engine-kmp/pull/172](https://github.com/krzema12/snakeyaml-engine-kmp/pull/172)
- Simplify `CharConstants.escapeChar()` by
[@&#8203;aSemy](https://github.com/aSemy) in
[https://github.com/krzema12/snakeyaml-engine-kmp/pull/171](https://github.com/krzema12/snakeyaml-engine-kmp/pull/171)
- Refactor YamlUnicodeReader by
[@&#8203;aSemy](https://github.com/aSemy) in
[https://github.com/krzema12/snakeyaml-engine-kmp/pull/169](https://github.com/krzema12/snakeyaml-engine-kmp/pull/169)
- refactor JsonSchema to avoid unnecessary expect/actual class by
[@&#8203;aSemy](https://github.com/aSemy) in
[https://github.com/krzema12/snakeyaml-engine-kmp/pull/168](https://github.com/krzema12/snakeyaml-engine-kmp/pull/168)
- Add source-code link to Dokka docs by
[@&#8203;aSemy](https://github.com/aSemy) in
[https://github.com/krzema12/snakeyaml-engine-kmp/pull/174](https://github.com/krzema12/snakeyaml-engine-kmp/pull/174)
- Refactor Parse by [@&#8203;aSemy](https://github.com/aSemy) in
[https://github.com/krzema12/snakeyaml-engine-kmp/pull/175](https://github.com/krzema12/snakeyaml-engine-kmp/pull/175)
- Update YamlIterator to implement Iterator, not MutableIterator by
[@&#8203;aSemy](https://github.com/aSemy) in
[https://github.com/krzema12/snakeyaml-engine-kmp/pull/180](https://github.com/krzema12/snakeyaml-engine-kmp/pull/180)
- Refactor Compose by [@&#8203;aSemy](https://github.com/aSemy) in
[https://github.com/krzema12/snakeyaml-engine-kmp/pull/176](https://github.com/krzema12/snakeyaml-engine-kmp/pull/176)
- refactor YamlOutputStreamWriter by
[@&#8203;aSemy](https://github.com/aSemy) in
[https://github.com/krzema12/snakeyaml-engine-kmp/pull/178](https://github.com/krzema12/snakeyaml-engine-kmp/pull/178)
- Remove BOM skip in ScannerImpl by
[@&#8203;aSemy](https://github.com/aSemy) in
[https://github.com/krzema12/snakeyaml-engine-kmp/pull/186](https://github.com/krzema12/snakeyaml-engine-kmp/pull/186)
- Remove deprecated Tag constructor by
[@&#8203;aSemy](https://github.com/aSemy) in
[https://github.com/krzema12/snakeyaml-engine-kmp/pull/190](https://github.com/krzema12/snakeyaml-engine-kmp/pull/190)
- Cherrypick test from upstream: Fix issue 51 - use the full buffer by
[@&#8203;aSemy](https://github.com/aSemy) in
[https://github.com/krzema12/snakeyaml-engine-kmp/pull/183](https://github.com/krzema12/snakeyaml-engine-kmp/pull/183)
- Add StreamReader tests by [@&#8203;aSemy](https://github.com/aSemy)
in
[https://github.com/krzema12/snakeyaml-engine-kmp/pull/185](https://github.com/krzema12/snakeyaml-engine-kmp/pull/185)
- Kotlin 2.0.0 by [@&#8203;aSemy](https://github.com/aSemy) in
[https://github.com/krzema12/snakeyaml-engine-kmp/pull/187](https://github.com/krzema12/snakeyaml-engine-kmp/pull/187)
- Refactor Mark by [@&#8203;aSemy](https://github.com/aSemy) in
[https://github.com/krzema12/snakeyaml-engine-kmp/pull/182](https://github.com/krzema12/snakeyaml-engine-kmp/pull/182)
- Refactor Load by [@&#8203;aSemy](https://github.com/aSemy) in
[https://github.com/krzema12/snakeyaml-engine-kmp/pull/181](https://github.com/krzema12/snakeyaml-engine-kmp/pull/181)

**Full Changelog**:
krzema12/snakeyaml-engine-kmp@v2.7.5...v3.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/typesafegithub/github-workflows-kt).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Piotr Krzeminski <[email protected]>
Co-authored-by: Piotr Krzemiński <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzema12 krzema12 krzema12 approved these changes

Assignees

@aSemy aSemy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aSemy @krzema12