Simplify CharConstants.escapeChar()
#171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzema12
approved these changes
May 10, 2024
krzema12
referenced
this pull request
in typesafegithub/github-workflows-kt
Jun 8, 2024
…#1475) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [it.krzeminski:snakeyaml-engine-kmp](https://github.com/krzema12/snakeyaml-engine-kmp) | `2.7.5` -> `3.0.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>krzema12/snakeyaml-engine-kmp (it.krzeminski:snakeyaml-engine-kmp)</summary> ### [`v3.0.0`](https://github.com/krzema12/snakeyaml-engine-kmp/releases/tag/v3.0.0) ### TODO: refine the release notes to enumerate breaking changes #### 💣 Breaking changes - change package from `org.snakeyaml.engine.v2` to `it.krzeminski.snakeyaml.engine.kmp` by [@​aSemy](https://github.com/aSemy) in [https://github.com/krzema12/snakeyaml-engine-kmp/pull/158](https://github.com/krzema12/snakeyaml-engine-kmp/pull/158) - TODO: add more #### 🌟 Features - Add wasmJs target by [@​krzema12](https://github.com/krzema12) in [https://github.com/krzema12/snakeyaml-engine-kmp/pull/191](https://github.com/krzema12/snakeyaml-engine-kmp/pull/191) #### Other changes - Update dependency org.jetbrains.kotlin:kotlin-gradle-plugin to v1.9.24 by [@​renovate](https://github.com/renovate) in [https://github.com/krzema12/snakeyaml-engine-kmp/pull/162](https://github.com/krzema12/snakeyaml-engine-kmp/pull/162) - Emitter: Add message for Unexpected Event.ID error by [@​aSemy](https://github.com/aSemy) in [https://github.com/krzema12/snakeyaml-engine-kmp/pull/170](https://github.com/krzema12/snakeyaml-engine-kmp/pull/170) - Fix scanning for tabs in plain-spaces by [@​aSemy](https://github.com/aSemy) in [https://github.com/krzema12/snakeyaml-engine-kmp/pull/173](https://github.com/krzema12/snakeyaml-engine-kmp/pull/173) - Refactor StandardConstructor by [@​aSemy](https://github.com/aSemy) in [https://github.com/krzema12/snakeyaml-engine-kmp/pull/172](https://github.com/krzema12/snakeyaml-engine-kmp/pull/172) - Simplify `CharConstants.escapeChar()` by [@​aSemy](https://github.com/aSemy) in [https://github.com/krzema12/snakeyaml-engine-kmp/pull/171](https://github.com/krzema12/snakeyaml-engine-kmp/pull/171) - Refactor YamlUnicodeReader by [@​aSemy](https://github.com/aSemy) in [https://github.com/krzema12/snakeyaml-engine-kmp/pull/169](https://github.com/krzema12/snakeyaml-engine-kmp/pull/169) - refactor JsonSchema to avoid unnecessary expect/actual class by [@​aSemy](https://github.com/aSemy) in [https://github.com/krzema12/snakeyaml-engine-kmp/pull/168](https://github.com/krzema12/snakeyaml-engine-kmp/pull/168) - Add source-code link to Dokka docs by [@​aSemy](https://github.com/aSemy) in [https://github.com/krzema12/snakeyaml-engine-kmp/pull/174](https://github.com/krzema12/snakeyaml-engine-kmp/pull/174) - Refactor Parse by [@​aSemy](https://github.com/aSemy) in [https://github.com/krzema12/snakeyaml-engine-kmp/pull/175](https://github.com/krzema12/snakeyaml-engine-kmp/pull/175) - Update YamlIterator to implement Iterator, not MutableIterator by [@​aSemy](https://github.com/aSemy) in [https://github.com/krzema12/snakeyaml-engine-kmp/pull/180](https://github.com/krzema12/snakeyaml-engine-kmp/pull/180) - Refactor Compose by [@​aSemy](https://github.com/aSemy) in [https://github.com/krzema12/snakeyaml-engine-kmp/pull/176](https://github.com/krzema12/snakeyaml-engine-kmp/pull/176) - refactor YamlOutputStreamWriter by [@​aSemy](https://github.com/aSemy) in [https://github.com/krzema12/snakeyaml-engine-kmp/pull/178](https://github.com/krzema12/snakeyaml-engine-kmp/pull/178) - Remove BOM skip in ScannerImpl by [@​aSemy](https://github.com/aSemy) in [https://github.com/krzema12/snakeyaml-engine-kmp/pull/186](https://github.com/krzema12/snakeyaml-engine-kmp/pull/186) - Remove deprecated Tag constructor by [@​aSemy](https://github.com/aSemy) in [https://github.com/krzema12/snakeyaml-engine-kmp/pull/190](https://github.com/krzema12/snakeyaml-engine-kmp/pull/190) - Cherrypick test from upstream: Fix issue 51 - use the full buffer by [@​aSemy](https://github.com/aSemy) in [https://github.com/krzema12/snakeyaml-engine-kmp/pull/183](https://github.com/krzema12/snakeyaml-engine-kmp/pull/183) - Add StreamReader tests by [@​aSemy](https://github.com/aSemy) in [https://github.com/krzema12/snakeyaml-engine-kmp/pull/185](https://github.com/krzema12/snakeyaml-engine-kmp/pull/185) - Kotlin 2.0.0 by [@​aSemy](https://github.com/aSemy) in [https://github.com/krzema12/snakeyaml-engine-kmp/pull/187](https://github.com/krzema12/snakeyaml-engine-kmp/pull/187) - Refactor Mark by [@​aSemy](https://github.com/aSemy) in [https://github.com/krzema12/snakeyaml-engine-kmp/pull/182](https://github.com/krzema12/snakeyaml-engine-kmp/pull/182) - Refactor Load by [@​aSemy](https://github.com/aSemy) in [https://github.com/krzema12/snakeyaml-engine-kmp/pull/181](https://github.com/krzema12/snakeyaml-engine-kmp/pull/181) **Full Changelog**: krzema12/snakeyaml-engine-kmp@v2.7.5...v3.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/typesafegithub/github-workflows-kt). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Piotr Krzeminski <[email protected]> Co-authored-by: Piotr Krzemiński <[email protected]>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify
CharConstants.escapeChar()for 1. readability, and 2. performance (currently it iterates multiple times throughESCAPE_REPLACEMENTS- which can be avoided).