Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wasm tests fail on Kotlin 2.1.0 and/or Kotest 6.0 #320

Closed
krzema12 opened this issue Jan 2, 2025 · 1 comment · Fixed by #336
Closed

Wasm tests fail on Kotlin 2.1.0 and/or Kotest 6.0 #320

krzema12 opened this issue Jan 2, 2025 · 1 comment · Fixed by #336
Assignees
@krzema12

Comments

@krzema12
Copy link
Owner

krzema12 commented Jan 2, 2025

See #231

We want to unblock releasing the newest version of the lib, and since Wasm is experimental in general, we'll skip these tests. A related discussion is happening in https://kotlinlang.slack.com/archives/CDFP59223/p1734964013996149 where we hope to understand the problem better. This issue is here to remember about revisiting this problem.
@krzema12 krzema12 mentioned this issue Jan 2, 2025
Merged
krzema12 added a commit that referenced this issue Jan 2, 2025
@krzema12
Temporarily disable Wasm tests (#321)
df708f0 
It's related to
#231.

The test fail on Kotlin 2.1.0 and/or Kotest 6.0, and we don't know why
yet. Given that Wasm is still experimental and unstable, we want to
release the library for other targets. That's why I recommend disabling
the tests, and tracking the issue in
#320. Once the
tests are skipped, we'll be able to unblock merging
#231 (I tested this
change with the mentioned PR and CI is green).

This change is made in a separate PR for visibility.
@krzema12
Copy link
Owner Author

krzema12 commented Jan 7, 2025

#336

@krzema12 krzema12 linked a pull request Jan 7, 2025 that will close this issue
Re-enable WASM JS tests #336
Merged
@krzema12 krzema12 self-assigned this Jan 7, 2025
@krzema12 krzema12 mentioned this issue Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krzema12 krzema12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-enable WASM JS tests krzema12/snakeyaml-engine-kmp
1 participant
@krzema12