New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ABF-9123 Add YAMPE_AVG_5 constant to tax-ca #525

Merged

toby-daigle merged 2 commits into master from dev/ABF-9123

Jan 7, 2025

Collaborator

toby-daigle commented Jan 7, 2025

What changed.

Sortir PENSIONABLE_EARNINGS de CONTRIBUTIONS, car les constantes sont également utilisées pour calculer les revenus et pas seulement les contributions.
Renommer les MAX, MIN, et AVG pour que ça ce soit exactement le jargon du domaine.
Ajouter la constante YAMPE_AVG_5
Déplacer les fonctions au bas du fichier et les constantes au début.

Code quality

New features are unit tested.

toby-daigle added 2 commits

January 7, 2025 16:22


          ABF-9123 dev(PublicPensionPlan): Add YAMPE_AVG_5 constant

ca6e7bc


          Move constant to top of object for QPP & CPP

f71441d

toby-daigle requested a review from a team as a code owner

January 7, 2025 21:39

toby-daigle changed the title ~~ABF-9123~~ ABF-9123 Add YAMPE_AVG_5 constant to tax-ca

faroukhoumaidi approved these changes

View reviewed changes

toby-daigle merged commit 6e86809 into master

9 checks passed

toby-daigle deleted the dev/ABF-9123 branch

January 7, 2025 21:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet