Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #55 overflow issue #58

Merged
merged 4 commits into from
Apr 25, 2015
Merged

Fix #55 overflow issue #58

merged 4 commits into from
Apr 25, 2015

Conversation

Macil
Copy link
Contributor

@Macil Macil commented Apr 22, 2015

If a bit more than 2048 tasks (capacity*2) were scheduled, asap would break and continue to spew exceptions.

Fixes #55.

Macil added 4 commits April 22, 2015 11:34
@Macil
add test for #55
04620ba
@Macil
fix #55
35ca933 
The old logic only shifted up to (index) values, but that number was
actually the number of values we did not need to shift. We needed to
shift (length - index) values.
@Macil
test ordering of tasks in capacity tests
59c3441
@Macil
don't do the subtraction on every loop iteration
3e5b001
@kriskowal kriskowal merged commit 3e5b001 into kriskowal:master Apr 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

asap queue can be effectively overflown (using [email protected])
2 participants
@Macil @kriskowal