Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Rewrite as wrapper hook #78

Merged
merged 4 commits into from
Oct 10, 2019

Conversation

JoseRFelix
Copy link
Contributor

@JoseRFelix JoseRFelix commented Oct 9, 2019

Rewrote the useToggle as a wrapper hook. However, I believe the user may want to use the old interface. Would it be a good idea to create another hook similar to useLocalStorage?

If you think the implementation is good I can proceed to update the file documentation accordingly.

Issue #36

@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #78 into master will decrease coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   89.38%   89.23%   -0.15%     
==========================================
  Files          27       27              
  Lines         292      288       -4     
  Branches       34       32       -2     
==========================================
- Hits          261      257       -4     
  Misses         26       26              
  Partials        5        5
Impacted Files Coverage Δ
src/useToggle.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b6b152...904dddc. Read the comment docs.

@kripod kripod merged commit ddafe8e into kripod:master Oct 10, 2019
@kripod
Copy link
Owner

kripod commented Oct 10, 2019

Thanks for contributing again!

@all-contributors please add @Jfelix61 for code

@allcontributors
Copy link
Contributor

@kripod

I've put up a pull request to add @Jfelix61! 🎉

kripod added a commit that referenced this pull request Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants