refactor(Button): unconstrain children

kripod · Jul 15, 2024 · 0d1ae6d · 0d1ae6d
1 parent f3db1af
commit 0d1ae6d
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/src/components/Button.tsx b/src/components/Button.tsx
@@ -8,7 +8,6 @@ export interface ButtonProps extends React.ComponentPropsWithRef<"button"> {
   size?: "auto" | "sm" | "md" | "lg";
   icon?: React.ReactNode;
   shape?: "rectangle" | "pill";
-  children?: string;
 }
 
 const defaultRender: ButtonProps["render"] = (props) => (
@@ -41,14 +40,11 @@ export const Button = forwardRef(function Button(
           size === "lg" && "gap-1.5 px-6",
         ),
     ),
-    children:
-      icon == null ? (
-        children
-      ) : (
-        <>
-          {icon} {children}
-        </>
-      ),
+    children: (
+      <>
+        {icon} <span>{children}</span>
+      </>
+    ),
     ...props,
   });
 });