Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #120 Use ActiveModel for size file validation #Issue 120 #122

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

sbhawsingka
Copy link
Collaborator

No description provided.

@ssinghi ssinghi changed the title Use ActiveModel for size file validatiom #Issue 120 Fixes #120 Use ActiveModel for size file validatiom #Issue 120 Aug 9, 2023
@ssinghi
Copy link

ssinghi commented Aug 9, 2023

@michel-victor can you please review this

@sbhawsingka sbhawsingka changed the title Fixes #120 Use ActiveModel for size file validatiom #Issue 120 Fixes #120 Use ActiveModel for size file validation #Issue 120 Aug 11, 2023
Copy link

@jasonpenny jasonpenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this makes sense, since ActiveModel is marked as a dependency of the gem, but ActiveRecord is only a development dependency

@michel-victor
Copy link

Thank you so much!!!

@ssinghi ssinghi merged commit 743979b into master Aug 15, 2023
@ssinghi ssinghi deleted the issue-120 branch August 15, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants