Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ScarletsFrame #849

Merged
merged 1 commit into from
Jan 9, 2021
Merged

Update ScarletsFrame #849

merged 1 commit into from
Jan 9, 2021

Conversation

StefansArya
Copy link
Contributor

Hi, I have updated the framework to v0.33.1 for keyed and non-keyed.
The non-keyed version will still have state on the model #800 because I want to check how is the impact of having the state on the model for this framework on the future. Thanks!

@krausest krausest merged commit a554726 into krausest:master Jan 9, 2021
@krausest
Copy link
Owner

krausest commented Jan 9, 2021

Thanks - and sorry for the long delay. Here's a screenshot of the results (left new, right old):

@StefansArya
Copy link
Contributor Author

It's okay, I just waited not long ago.
Looks like the select row was 17ms slower and now it catches my eye because it has turned yellow.

Anyway, thank you so much for maintaining this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants