Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Svelte to 1.58 #367

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Conversation

Rich-Harris
Copy link
Contributor

hey — this updates the Svelte benchmarks to version 1.58, which fixes our abysmal row swapping performance. Thanks!

@krausest krausest merged commit 6b1197f into krausest:master Mar 19, 2018
@krausest
Copy link
Owner

Thanks - but I'm afraid the keyed version looks horribly wrong:
https://www.rawgit.com/krausest/js-framework-benchmark/802a2ccf15857ef89ea0f5f7be6b88afab72b8fa/webdriver-ts-results/table.html
bildschirmfoto 2018-03-19 um 22 00 41

I've checked in the chrome timeline and can confirm that the measurement e.g. for select row seems correct:
bildschirmfoto 2018-03-19 um 22 01 13
The non-keyed version is also a bit slower, but much closer:
bildschirmfoto 2018-03-19 um 22 03 58
Can you please check what's wrong with it?

@Rich-Harris
Copy link
Contributor Author

yikes! not sure what happened there. This is what it looked like shortly before I cut 1.58: http://windy-able.surge.sh/

screen shot 2018-03-19 at 5 16 30 pm

I made some further changes, but only to tidy things up slightly (or so I thought) — I most have broken something badly. Will investigate. Thanks for the heads up!

@krausest
Copy link
Owner

I can confirm that if I change the version to 1.57.4 I'm seeing good performance. This is select row for 1.57.4:

bildschirmfoto 2018-03-19 um 22 41 44

And when I switch back to 1.58.0 I get:
bildschirmfoto 2018-03-19 um 22 44 02

@Rich-Harris Rich-Harris deleted the update-svelte branch March 26, 2018 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants