implement optimization from #166

krausest · Apr 22, 2017 · ee0a610 · ee0a610
1 parent 5d7a88e
commit ee0a610
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 11 deletions.
diff --git a/vanillajs-keyed/src/Main.js b/vanillajs-keyed/src/Main.js
@@ -243,7 +243,6 @@ class Main {
         this.rows.splice(idx, 1);
         this.data.splice(idx, 1);
         this.unselect();
-
         this.recreateSelection();
         stopMeasure();
     }
@@ -283,13 +282,15 @@ class Main {
     }
     clear() {
         startMeasure("clear");
-        this.removeAllRows();
         this.store.clear();
         this.rows = [];
         this.data = [];
-        this.unselect();
-        stopMeasure();
-    }
+        requestAnimationFrame(() => {
+            this.removeAllRows();
+            this.unselect();
+            stopMeasure();
+        });
+    }    
     swapRows() {
         startMeasure("swapRows");
         if (this.data.length>10) {

diff --git a/vanillajs-non-keyed/src/Main.js b/vanillajs-non-keyed/src/Main.js
@@ -292,13 +292,15 @@ class Main {
     }
     clear() {
         startMeasure("clear");
-        this.removeAllRows();
         this.store.clear();
         this.rows = [];
         this.data = [];
-        this.unselect();
-        stopMeasure();
-    }
+        requestAnimationFrame(() => {
+            this.removeAllRows();
+            this.unselect();
+            stopMeasure();
+        });
+    }    
     swapRows() {
         startMeasure("swapRows");
         let old_selection = this.store.selected;

diff --git a/webdriver-ts/table.html b/webdriver-ts/table.html