fix: only throwing errors for major version changes #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
=======================================
Coverage 95.64% 95.64%
=======================================
Files 18 18
Lines 1217 1218 +1
=======================================
+ Hits 1164 1165 +1
Misses 53 53
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
gregjopa
reviewed
Apr 25, 2023
wsbrunson
approved these changes
Apr 25, 2023
spencersablan
approved these changes
Apr 25, 2023
gregjopa
reviewed
Apr 25, 2023
src/child/child.js
Outdated
| @@ -74,6 +74,22 @@ function destroy(): ZalgoPromise<void> { | |||
| }); | |||
| } | |||
|
|
|||
| // This function will only compare the first numerical value, | |||
There was a problem hiding this comment.
Suggested change
| // This function will only compare the first numerical value, | |
| // Compares the first numerical value of the parent and child versions of zoid | |
| // to help throw an error when the major version number is different. |
gregjopa
reviewed
Apr 25, 2023
gregjopa
approved these changes
Apr 25, 2023
gregjopa
pushed a commit
that referenced
this pull request
Apr 25, 2023
Update existing error handling logic to only throw errors when the major version number is different between the parent and child windows. This assumes that minor and patch releases make no breaking changes to post message communication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently throw an error when the Zoid version doesn't strictly match. This change will only check for major version upgrades before throwing an error, patches and minor changes will be allowed to be different.