-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(iframe): add empty srcdoc attribute to iframe elem if not exist #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
@magaldima once we merge this pr: #37 you should be able to rebase your branch on |
84939fb
to
5a7f781
Compare
@wsbrunson just rebased but I still see the CI failing |
Did the pre-commit hooks run when you first committed? If not, you'll want to run |
Just did and pushed up update. |
|
This PR fixes an issue with embedding iframe elements via jsx-pragmatic that do not specify a
src
orsrcdoc
property. This issue manifests itself while using zoid to render a cross-origin iframe within an "anonymous" iframe on Safari >=17.