Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iframe): add empty srcdoc attribute to iframe elem if not exist #36

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

magaldima
Copy link
Contributor

This PR fixes an issue with embedding iframe elements via jsx-pragmatic that do not specify a src or srcdoc property. This issue manifests itself while using zoid to render a cross-origin iframe within an "anonymous" iframe on Safari >=17.

@magaldima magaldima requested a review from a team as a code owner September 19, 2024 14:25
Copy link
Collaborator

@bluepnume bluepnume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

src/renderers/dom.js Outdated Show resolved Hide resolved
Copy link

@ravishekhar ravishekhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@wsbrunson
Copy link
Member

@magaldima once we merge this pr: #37

you should be able to rebase your branch on main and CI will pass

@magaldima
Copy link
Contributor Author

@magaldima once we merge this pr: #37

you should be able to rebase your branch on main and CI will pass

@wsbrunson just rebased but I still see the CI failing

@wsbrunson
Copy link
Member

Did the pre-commit hooks run when you first committed? If not, you'll want to run npm run format for prettier to be applied to your change

@magaldima
Copy link
Contributor Author

Did the pre-commit hooks run when you first committed? If not, you'll want to run npm run format for prettier to be applied to your change

Just did and pushed up update.

@wsbrunson wsbrunson merged commit b21a468 into krakenjs:main Sep 23, 2024
1 check passed
@wsbrunson
Copy link
Member

@magaldima

A new version of the package @krakenjs/jsx-pragmatic (3.1.0) was published at 2024-09-23T15:38:03.632Z from 20.172.5.91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants