Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync port forward wrapping should call async_run_forever #567

Merged

Conversation

jacobtomlinson
Copy link
Member

Closes #566

@jacobtomlinson jacobtomlinson changed the title Sync port forward wrapping should call async_run_forever Sync port forward wrapping should call async_run_forever Jan 27, 2025
@github-actions github-actions bot added the kr8s label Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.09%. Comparing base (87063fc) to head (18a1701).
Report is 173 commits behind head on main.

Files with missing lines Patch % Lines
kr8s/portforward.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
- Coverage   94.61%   94.09%   -0.53%     
==========================================
  Files          29       30       +1     
  Lines        3141     4214    +1073     
==========================================
+ Hits         2972     3965     +993     
- Misses        169      249      +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobtomlinson jacobtomlinson merged commit 52a2356 into kr8s-org:main Jan 27, 2025
13 checks passed
@jacobtomlinson jacobtomlinson deleted the port-forward-run-forever branch January 27, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Expected coroutine function, got method" error when portforwarding
1 participant