-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement omision of zeroed-fields with + flag #69
base: main
Are you sure you want to change the base?
Conversation
456249b
to
cfd0d4d
Compare
@kr friendly ping :) |
@kr any chance of taking a look at this anytime soon? |
I like the idea of omitting zero fields, since that's pretty common in Go source code to begin with. But maybe it should not be an option. I'm not sure retaining the ability to print zero fields carries its weight. What do you think? |
Or, if it should be an option, maybe the notation should be |
No strong opinions here. I can implement whichever option you prefer. just let me know :) |
I have given a Go to @kr what do you say? It's already been a month since I submitted the PR and I would like it to move forward. Thanks! |
@kr friendly ping |
1 similar comment
@kr friendly ping |
+1 for this feature. Regarding format, I'd omit zero values by default (with |
@kr friendly ping |
Fixes #59
This PR binds the
'+'
formatting flag to omitting empty (zero-valued) struct fields.