rollouts: add status conditions to remote root sync

[ChristopherFry]

This pull request adds the kstatus Reconciling and Stalled conditions status conditions to the Remote Root Sync.

[natasha41575]

Thanks! Some small nits

[droot]

Can you please add a TODO here:
Reconciling or Stalled condition should be updated (or externalSync conditions should be added) by examining syncStatus. SyncStatus could have values Stalled, Reconciling, Error, Pending even when syncError is nil.

[ChristopherFry]

I don't think we want actually do this with these being kstatus conditions. From my understanding, the Reconciling and Stalled conditions (in the case of the remote root sync) should only consider if the root sync is created and up to date with the latest spec as defined by the remote root sync, regardless of the sync status of the root sync. When the Reconciling condition is set to true it implies that the Remote Root Sync still needs to reconcile the root sync with the lates spec from the remote root sync. @mortent can you confirm?

[droot]

if the root sync is created and up to date with the latest spec as defined by the remote root sync

You are right and that's where my comment come from. If you look at checkSyncStatus, it can return Pending status without any error when generation != observedGeneration (meaning rootsync is not up to date with the latest spec of rootsync). I think for other values Stalled, Reconciling, Error, we will have to create an extra condition to track externalSyncStatus or something.

Never mind. I misunderstood what you meant up there :). I will capture out yesterday's discussion in another issue, I think that would be better.