packagevariant controller should unpropose deletion when needed #3759
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this scenario when playing around with the packagevariant controller:
foo
. The PackageVariant controller creates the target draft package revision, and I publish it, resulting infoo v1
.bar
. The PackageVariant controller creates a new target draft package revisionbar
. It also sees that it owns a package revisionfoo v1
that no longer matches its target, so proposesfoo v1
for deletion. This is working great so far.foo
. The PackageVariant controller deletes its package revisionbar
. The controller also sees that there is already a package revisionfoo v1
that it owns that matches its target, so it does nothing -- meaning thatfoo v1
stays proposed for deletion. This PR makes it so that in such a case, the target package revision's lifecycle gets changed back from DeletionProposed to Published.