Add PackageVariantSet controller #3707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natasha41575
changed the title
natasha41575
force-pushed
the
UpstreamPolicy
branch
4 times, most recently
from
c89d2e6 to
123fabb
Compare
natasha41575
changed the title
natasha41575
force-pushed
the
UpstreamPolicy
branch
5 times, most recently
from
217c2ad to
9dd1910
Compare
natasha41575
force-pushed
the
UpstreamPolicy
branch
from
9dd1910 to
2dc6b40
Compare
natasha41575
changed the title
mortent
reviewed
Jan 24, 2023
porch/controllers/packagevariants/api/v1alpha1/packagevariant_types.go
Outdated
Show resolved
Hide resolved
porch/controllers/packagevariants/pkg/controllers/packagevariant/packagevariant_controller.go
Outdated
Show resolved
Hide resolved
porch/controllers/packagevariants/pkg/controllers/packagevariant/packagevariant_controller.go
Outdated
Show resolved
Hide resolved
...rollers/packagevariantsets/pkg/controllers/packagevariantset/packagevariantset_controller.go
Outdated
Show resolved
Hide resolved
porch/controllers/packagevariantsets/api/v1alpha1/packagevariantset_types.go
Outdated
Show resolved
Hide resolved
porch/controllers/packagevariantsets/api/v1alpha1/packagevariantset_types.go
Outdated
Show resolved
Hide resolved
...rollers/packagevariantsets/pkg/controllers/packagevariantset/packagevariantset_controller.go
Show resolved
Hide resolved
natasha41575
force-pushed
the
UpstreamPolicy
branch
from
f8bf766 to
f321b65
Compare
mortent
approved these changes
Jan 26, 2023
...rollers/packagevariantsets/pkg/controllers/packagevariantset/packagevariantset_controller.go
Show resolved
Hide resolved
mortent
approved these changes
Jan 27, 2023
...rollers/packagevariantsets/pkg/controllers/packagevariantset/packagevariantset_controller.go
Show resolved
Hide resolved
|
Woohoo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the UpstreamPolicy (renamed to PackageVariantSet) as described in this doc and discussed in #3488.
There are some TODOs in this PR that I am working on in a follow-up:
This PR also adds a finalizer to the PackageVariant controller to make sure that it cleans up properly before being deleted. (I noticed some issues with its cleanup while trying out the PackageVariantSet controller.)
Relevant issue: #3488