Provide version to RESTMapper in WorkloadIdentityBinding controller #3666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve Agree we should fix it, though I think that it's very rare that we don't care about the version in a controller (?) If that's true, making this an explicit error is not a bad behaviour (?) |
justinsb
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the WorkloadIdentityBinding controller. The new implementation of the RESTMapper interface that was added in #3567 differs from the regular implementation in that it requires that the version is provided when calling the
RESTMappingfunction. This updates the controller to provide the version when use that function.We should consider fixing the behavior in the RESTMapper implementation, as this differs from the regular implementation.