Add RootSyncDeployment controller #3653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortent
force-pushed
the
RootSyncDeployment
branch
from
91c898c to
e68c218
Compare
natasha41575
approved these changes
Nov 14, 2022
| } | ||
|
|
||
| type result struct { | ||
| apiVersion string |
There was a problem hiding this comment.
Why make a new type here instead of just using the ClusterRefStatus type directly?
There was a problem hiding this comment.
Hmm that is an excellent question. I've updated the PR to just use ClusterRefStatus directly.
mortent
force-pushed
the
RootSyncDeployment
branch
from
e68c218 to
2f96bb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new CRD and controller that builds upon the RootSyncSet type to support progressive rollouts of PackageRevisions from Porch. It uses label selectors to find remote clusters represented as Config Connector resources in the local cluster and then creates RootSyncSet resources representing each. Whenever the referenced PackageRevision is changed, the update will be rolled out progressively. Sync status is currently the only signal, but we can expand on that to include reconciliation status and possibly other external systems.
Demo: https://drive.google.com/file/d/1zlqlSLNOR25v8Kb9qOAXd-ymRHkxOCRh/view?usp=share_link