fix non-US-ascii characters #3622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
through an old-fashioned system towards our cluster, that the contents of the description weren't fully in US-ASCII format. this commit fixes that.
justinsb
approved these changes
Oct 14, 2022
|
Thanks for fixing - lgtm. I'm also going to open a bug because we probably should at least be using go:embed for this, and probably should think about how we keep this CRD up to date. |
wmuizelaar
added a commit
to wmuizelaar/kpt
that referenced
this pull request
Oct 18, 2022
… attempt to fix things. See kptdev#3622.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into an issue where applying the resourcegroup.kpt.dev CRD through an old-fashioned system towards our cluster, that the contents of the description weren't fully in US-ASCII format.
This commit fixes that.