porch: restrict clone and init to only create the first package revision
#3603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natasha41575
requested review from
droot,
justinsb,
mortent and
yuwenma
as code owners
natasha41575
changed the title
clone and init to only create the first package revision
natasha41575
force-pushed
the
cloneInitRestrictions
branch
3 times, most recently
from
dee08cc to
442c310
Compare
|
cc @yuwenma |
yuwenma
reviewed
Oct 7, 2022
justinsb
approved these changes
Oct 14, 2022
commands/alpha/rpkg/clone/command.go
Outdated
| return err | ||
| } | ||
| for _, pr := range packageRevisionList.Items { | ||
| if pr.Spec.RepositoryName == r.repository && pr.Spec.PackageName == packageName { |
There was a problem hiding this comment.
I think we support fieldSelectors today, but if/when we get to CRDs we likely won't, so ... fine for now!
|
This seems fine, though possibly moot once we have workspaces (which I think you're working on in parallel). If it helps you before workspaces, LGTM! |
natasha41575
force-pushed
the
cloneInitRestrictions
branch
2 times, most recently
from
5cd583b to
ba12df0
Compare
natasha41575
changed the title
clone and init to only create the first package revisionclone and init to only create the first package revision
natasha41575
force-pushed
the
cloneInitRestrictions
branch
2 times, most recently
from
82472a7 to
8699a13
Compare
natasha41575
force-pushed
the
cloneInitRestrictions
branch
3 times, most recently
from
6092fc7 to
0f6ccca
Compare
natasha41575
force-pushed
the
cloneInitRestrictions
branch
from
0f6ccca to
3ed6d8e
Compare
mortent
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially implements #3467 (comment)
Only the first package revision can be made by
initorclone. Subsequent package revisions should be created withedit/copy.This adds the check on both the CLI and server side.