Update the auth flags for registering repositories #3101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will eventually add support for other auth types than just basic auth. Therefore we need a convention for how we name the flags used for authentication against package repositories. This updates the current flags to follow the following convention:
repo-<auth type>-<input>
repo-
prefix to make it clear it pertains to repository auth (rather than cluster) and to avoid conflicts with existing flags we inherit from kubectl (examples are username and password).Following this convention, the flags for specifying username and password for basic auth results in the flags
repo-basic-username
andrepo-basic-password
.