Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS with the broader team #3099

Merged
merged 1 commit into from
May 6, 2022

Conversation

justinsb
Copy link
Contributor

@justinsb justinsb commented May 6, 2022

No description provided.

@justinsb justinsb requested a review from droot May 6, 2022 17:01
@justinsb justinsb force-pushed the update_codeowners branch from cf6316d to 0528c00 Compare May 6, 2022 17:01
@bgrant0607
Copy link
Contributor

It seems like the directories covered in the file are pretty arbitrary. Do we need them all? Are there some that are missing?

Also, I think all listed owners are spammed for reviews on PRs that touch those directories. I'd be happy not to be spammed on anything other than the site. :-)

@justinsb
Copy link
Contributor Author

justinsb commented May 6, 2022

So the original intent of the directories was that...

  • There would be one approver / one voice for all docs. A few packages referenced from the docs would also have tighter control.
  • Schema changes would get specially checked
  • Tests that enforce the function contract would get specially checked.

I'm proposing that we adopt more of a broader web of trust here, so all directories have the same permissions; given that I think it's less important about the directory coverage, but I do need to check about what happens to non-covered directories.

However, I ack that it is annoying if you get spammed. i.e. we're not just giving people permissions, we're also destroying their email. I'll set you specifically as only on the docs site if you like @bgrant0607 , and if anyone else wants to opt out, please LMK.

Some people have asked for minimal permissions, however, to avoid
notification spam.
@justinsb justinsb force-pushed the update_codeowners branch from 0528c00 to d41a40f Compare May 6, 2022 17:25
@justinsb justinsb merged commit d81c260 into kptdev:main May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants