applyset: introduce abstraction over objects #3077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us use typed and untyped objects.
|
cc @apelisse |
martinmaly
approved these changes
May 2, 2022
| "k8s.io/apimachinery/pkg/runtime/schema" | ||
| ) | ||
|
|
||
| type ApplyableObject interface { |
There was a problem hiding this comment.
This seems reasonable. I do wonder about some of the prior art interfaces that are similar but not quite the same. for example
runtime.Object has slightly different structure.
I prefer the straightforward simplicity of the ApplyableObject but it is worth checking whether there is a reason to go with some prior art already in place.
There was a problem hiding this comment.
Yeah, we typically get this information with the meta.Accessor from the runtime.Object
There was a problem hiding this comment.
Indeed, but the intent is that this isn't necessarily a runtime.Object. It is supposed to be easy to take an unstructured object or a typed object and use it though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us use typed and untyped objects.