Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alpha command group #2820

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Add alpha command group #2820

merged 2 commits into from
Feb 23, 2022

Conversation

martinmaly
Copy link
Contributor

No description provided.

@yuwenma
Copy link
Contributor

yuwenma commented Feb 23, 2022

/lgtm

Is this alpha command aimed to manage the release stages like gcloud alpha/beta, whose sub-commands will be moved out of the alpha list once mature? I'm wondering if the maintenance cost would be a concern for kpt since our scenarios are much simpler than gcloud. @martinmaly Would it be sufficient to add the "alpha" to command descriptions (or further, give warnings when users run the alpha command) and not introduce the new 'alpha' group? This can reduce the further migration (and backport) work.

@martinmaly
Copy link
Contributor Author

We probably could just add alpha descriptions. We need some place to quickly iterate on CLI UX related to porch, which is going to change rapidly. If there is exiting way to achieve this within kpt, happy to use it instead.

@droot
Copy link
Contributor

droot commented Feb 23, 2022

/lgtm

Is this alpha command aimed to manage the release stages like gcloud alpha/beta, whose sub-commands will be moved out of the alpha list once mature? I'm wondering if the maintenance cost would be a concern for kpt since our scenarios are much simpler than gcloud. @martinmaly Would it be sufficient to add the "alpha" to command descriptions (or further, give warnings when users run the alpha command) and not introduce the new 'alpha' group? This can reduce the further migration (and backport) work.

For new commands, having them under alpha group is a good practice because it communicates the maturity of the command very explicitly. The harder part is to test new behavior for existing commands, there introducing a new flag (or environment feature flag) and marking it experimental is probably the only way to go.

@martinmaly martinmaly merged commit c0b4a02 into kptdev:main Feb 23, 2022
@martinmaly martinmaly deleted the alpha branch February 23, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants