Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent formatting for eval #1985

Merged
merged 1 commit into from
May 12, 2021
Merged

Consistent formatting for eval #1985

merged 1 commit into from
May 12, 2021

Conversation

phanimarupaka
Copy link
Contributor

This PR is to introduce consistent formatting for eval command. If any function is invoked by eval, the resources are consistently formatted at the end.

#1973

Shell32-Natsu
Shell32-Natsu approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@Shell32-Natsu Shell32-Natsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but want to wait for approval from Frank or Sunil

droot
droot approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@droot droot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making it consistent with render seems ok to me.

@phanimarupaka phanimarupaka merged commit a6799e6 into kptdev:next May 12, 2021
@phanimarupaka phanimarupaka mentioned this pull request May 12, 2021
Merged
@mengqiy mengqiy mentioned this pull request May 13, 2021
Merged
frankfarzan pushed a commit to frankfarzan/kpt that referenced this pull request Jun 3, 2021
@phanimarupaka @frankfarzan
Consistent formatting for eval (kptdev#1985)
7538019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot droot approved these changes

@Shell32-Natsu Shell32-Natsu Shell32-Natsu approved these changes

@frankfarzan frankfarzan Awaiting requested review from frankfarzan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phanimarupaka @droot @Shell32-Natsu