Include repository address in the table rendering (#3061)

kptdev · Apr 26, 2022 · b64ceaf · b64ceaf
1 parent 2b2e097
commit b64ceaf
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/e2e/testdata/porch/repo-register/config.yaml b/e2e/testdata/porch/repo-register/config.yaml
@@ -31,8 +31,8 @@ commands:
       - get
       - --namespace=repo-register
     stdout: |
-      NAME              TYPE   CONTENT   DEPLOYMENT   READY
-      test-blueprints   git    Package                True
+      NAME              TYPE   CONTENT   DEPLOYMENT   READY   ADDRESS
+      test-blueprints   git    Package                True    https://github.com/platkrm/test-blueprints.git
   - args:
       - alpha
       - repo

diff --git a/e2e/testdata/porch/rpkg-init-deploy/config.yaml b/e2e/testdata/porch/rpkg-init-deploy/config.yaml
@@ -75,5 +75,5 @@ commands:
       - get
       - --namespace=rpkg-init-deploy
     stdout: |
-      NAME   TYPE   CONTENT   DEPLOYMENT   READY
-      git    git    Package   true         True
+      NAME   TYPE   CONTENT   DEPLOYMENT   READY   ADDRESS
+      git    git    Package   true         True    http://git-server.test-git-namespace.svc.cluster.local:8080
diff --git a/porch/api/porchconfig/v1alpha1/config.porch.kpt.dev_repositories.yaml b/porch/api/porchconfig/v1alpha1/config.porch.kpt.dev_repositories.yaml
@@ -42,6 +42,9 @@ spec:
     - jsonPath: .status.conditions[?(@.type=='Ready')].status
       name: Ready
       type: string
+    - jsonPath: .spec['git','oci']['repo','registry']
+      name: Address
+      type: string
     name: v1alpha1
     schema:
       openAPIV3Schema:

diff --git a/porch/api/porchconfig/v1alpha1/types.go b/porch/api/porchconfig/v1alpha1/types.go
@@ -25,6 +25,7 @@ import (
 //+kubebuilder:printcolumn:name="Content",type=string,JSONPath=`.spec.content`
 //+kubebuilder:printcolumn:name="Deployment",type=boolean,JSONPath=`.spec.deployment`
 //+kubebuilder:printcolumn:name="Ready",type=string,JSONPath=`.status.conditions[?(@.type=='Ready')].status`
+//+kubebuilder:printcolumn:name="Address",type=string,JSONPath=`.spec['git','oci']['repo','registry']`
 
 // Repository
 type Repository struct {