Skip to content

Commit

Permalink
RemoteRootSyncSet: Remove hack where we set namespace (#2724)
Browse files Browse the repository at this point in the history
It's now causing problems; we shouldn't need it and we should fix it
later in the logic anyway (with a default namespace).
  • Loading branch information
justinsb authored Feb 4, 2022
1 parent c194c7a commit 3354360
Showing 1 changed file with 0 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -290,12 +290,6 @@ func (r *RemoteRootSyncSetReconciler) BuildObjectsToApply(ctx context.Context, s
return nil, fmt.Errorf("error parsing yaml from %s: %w", item.Path, err)
}

// Hack: default namespace until we populate the namespace in our packages
if o.GetNamespace() == "" {
klog.Warningf("HACK: setting namespace to default")
o.SetNamespace("default")
}

// TODO: sync with kpt logic; skip objects marked with the local-only annotation
objects = append(objects, o)
}
Expand Down

0 comments on commit 3354360

Please sign in to comment.