no rust error msg and intro for pkg style printout #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpagacz
reviewed
Jan 27, 2025
| package_root <- dirname(package_root) | ||
| if (strsplit(package_root, split = .Platform$file.sep) |> length() == 1) { | ||
| parent_dir <- dirname(package_root) | ||
| if (parent_dir == package_root) { # Reached root without finding DESCRIPTION |
There was a problem hiding this comment.
Will this comparison behave nicely on Windows? I wouldn't want people to need to create two different styling scripts for Windows and Unix platforms because of backwards slashes.
kpagacz
reviewed
Jan 27, 2025
| # Format | ||
|
|
||
| # Define ANSI Color Codes and Unicode Symbols | ||
| green_tick <- "\u001B[32m\u2714\u001B[0m" |
kpagacz
reviewed
Jan 27, 2025
Co-authored-by: Konrad Pagacz <[email protected]>
kpagacz
reviewed
Jan 27, 2025
kpagacz
reviewed
Jan 27, 2025
kpagacz
reviewed
Jan 27, 2025
| #' | ||
| #' @export | ||
| style_pkg <- function(path = ".", | ||
| config_file = "tergo.toml", | ||
| configuration = list(), | ||
| force = FALSE, | ||
| extensions = c(".R", ".r")) { | ||
| extensions = c(".R", ".r"), | ||
| verbose = interactive()) { |
Co-authored-by: Konrad Pagacz <[email protected]>
Co-authored-by: Konrad Pagacz <[email protected]>
kpagacz
previously approved these changes
Jan 27, 2025
kpagacz
reviewed
Jan 27, 2025
| @@ -72,7 +72,15 @@ fn format_code(source_code: &str, configuration: extendr_api::List) -> String { | |||
| .unwrap_or(default_config.insert_newline_in_quote_call.0), | |||
| ); | |||
|
|
|||
| tergo_lib::tergo_format(source_code, Some(&config)).unwrap() | |||
|
|
|||
| match tergo_lib::tergo_format(source_code, Some(&config)) { | |||
There was a problem hiding this comment.
BTW, the issue of panics stemming from wrong configuration values still persists. It's all lines 15-75.
This was
linked to
issues
Jan 27, 2025
kpagacz
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We return a list not a string for format_code, the first list element is a status.
PS. We not want to use |> as it implies we expect at least R 4.1
Add a prototype nice style_pkg printout, I will polish it