Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

プロトコルバージョン6 #2

Merged
merged 5 commits into from
Feb 17, 2025
Merged

プロトコルバージョン6 #2

merged 5 commits into from
Feb 17, 2025

Conversation

kozakura913
Copy link
Owner

No description provided.

@kozakura913 kozakura913 marked this pull request as ready for review February 17, 2025 05:45
Misaki0331
Misaki0331 reviewed Feb 17, 2025
View reviewed changes
Copy link
Contributor

@Misaki0331 Misaki0331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

変わりそうな値をconstとして配置するのはソースコード探すの大変そうなので、定数はstructあたりにまとめた方が良いかも

Misaki0331
Misaki0331 approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@Misaki0331 Misaki0331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yosasou

@kozakura913 kozakura913 merged commit cdc3223 into master Feb 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Misaki0331 Misaki0331 Misaki0331 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kozakura913 @Misaki0331