Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support discriminators in array items #1458

Merged
merged 7 commits into from
Nov 24, 2023

Conversation

mesfahanisimscale
Copy link
Contributor

No description provided.

Copy link

codspeed-hq bot commented Nov 24, 2023

CodSpeed Performance Report

Merging #1458 will not alter performance

Comparing mesfahanisimscale:discriminator-in-array (f905fb3) with main (a31148d)

Summary

✅ 29 untouched benchmarks

@koxudaxi koxudaxi changed the title setup usecase for discriminators for array items Support discriminators for array items Nov 24, 2023
@koxudaxi koxudaxi changed the title Support discriminators for array items Support discriminators in array items Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@a31148d). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1458   +/-   ##
=======================================
  Coverage        ?   99.02%           
=======================================
  Files           ?       37           
  Lines           ?     4118           
  Branches        ?      957           
=======================================
  Hits            ?     4078           
  Misses          ?       25           
  Partials        ?       15           
Flag Coverage Δ
unittests 98.71% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koxudaxi koxudaxi merged commit 5ccc441 into koxudaxi:main Nov 24, 2023
@koxudaxi
Copy link
Owner

koxudaxi commented Dec 4, 2023

@mesfahanisimscale
The issue is fixed in the latest version.
Thank you very much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants