script_path / script_dir improvements
#375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irh
force-pushed
the
script-path-improvements
branch
from
18d0965 to
e361ddf
Compare
The existing approach of relying on the client to set the script path is brittle, and simply doesn't work for imported modules. A better approach is to defer to the path that's already stored in the Chunk, which works as expected for any module.
irh
force-pushed
the
script-path-improvements
branch
from
e361ddf to
b7bf074
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
koto.script_path/script_dirso that they're functions that always return the correct results, irrespective of the module that they're called from.Koto::set_script_pathhas been removed, and thecompile/compile_and_runfunctions now take aCompileArgsstruct that optionally includes the script path.