Fetch necessary git refs #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By fetching the pull head, we make sure that we have all commit shas available, even if the branch itself is already deleted from github. Ofcourse, we only want to fetch the head once, since it doesn't change for each of the different targets. And if none of the labels match, then we don't even have to fetch. Potentially this allows us to remove the `fetch-depth: 0` input from the checkout action. To achieve that goal, we'll need to also fetch each of the targets individually.
We don't always have to fetch: only when there are actual backport labels present. We only have to fetch the head once, but we need to make sure that we actually fetch and not forget about it. Then, we also need to fetch each of the targets.
It is no longer necessary to fetch all git history during the checkout, because the action is now fetching all necessary refs specifically. Since the fetch-depth 0 setting can be very slow for large projects, it is discouraged to use this now.
This is no longer necessary and new users should not be encouraged to use `fetch-depth: 0`.
This was referenced Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes sure the action fetches the necessary git refs so it has all necessary git history available. It uses
refs/pull/$num/headfor fetching the history that is part of the pull request that should be backported. This means that the action now works even when you've already deleted the branch of that pull request.This also removes the need for checking out the entire git history with the checkout action. Previously, the action required users to set the
fetch-depthto0for the checkout action. That looked like:Now, you can simply checkout the default branch:
This should significantly speed up running this action for projects with large git repos that have many refs hanging around.
These changes have been manually tested by deleting branch from https://github.com/zeebe-io/automation-lab/pull/56 and then triggering the action. See: https://github.com/zeebe-io/automation-lab/pull/56#issuecomment-935754194
resolves #90