Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes setting committer author/email #13

Merged
merged 3 commits into from
May 6, 2021
Merged

Fixes setting committer author/email #13

merged 3 commits into from
May 6, 2021

Conversation

npepinpe
Copy link
Contributor

@npepinpe npepinpe commented May 6, 2021

Overrides the committer author/email via environment variables instead of by using configuration options.

Overrides the committer author/email via environment variables instead
of by using configuration options.
@npepinpe npepinpe requested a review from korthout May 6, 2021 12:41
@npepinpe
Copy link
Contributor Author

npepinpe commented May 6, 2021

🤞

Copy link
Owner

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nice solution! I was unaware that env vars could be used to override the values.

Please also update test/setup.sh to use this, for consistency.

@npepinpe npepinpe requested a review from korthout May 6, 2021 13:35
@npepinpe
Copy link
Contributor Author

npepinpe commented May 6, 2021

I updated it, and now also enforce the environment variable instead of simply adding a default.

Copy link
Owner

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏆

@korthout korthout merged commit 1d6e5fe into master May 6, 2021
@korthout korthout deleted the np-fix-committer branch May 6, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants