Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce a common Mojo parameter skip #98

Merged
merged 2 commits into from
Sep 4, 2023
Merged

feat: Introduce a common Mojo parameter skip #98

merged 2 commits into from
Sep 4, 2023

Conversation

spencercjh
Copy link

RESOLVE #92

tisonkun
tisonkun reviewed Sep 1, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The changeset looks good.

I make some changes on #96 so you may need to rebase.

@spencercjh spencercjh requested a review from tisonkun September 1, 2023 03:26
tisonkun
tisonkun reviewed Sep 1, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Generally looks good. Maybe we should skip at the very beginning; that is, logging and return instead of logging an extra "Formatting license headers... with config" sentence.

tisonkun
tisonkun approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tisonkun tisonkun merged commit 4ebf210 into korandoru:main Sep 4, 2023
@spencercjh spencercjh deleted the feat/maven-plugin/skip branch September 5, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support skip Maven plugin execution
2 participants
@spencercjh @tisonkun