-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: skip leading bom if exist #166
Conversation
I've triggered the CI workflow for you. I'm not quite familiar with CSharp's BOM mechanism. A rough thought is to detect those characters and skip them always. |
Thx for triggering .Added exclusion for newly added folder, to get past some of the checks. |
@kinkelpk This repo has a setting to require approval for first-time contributor's PR. You can ping me to retrigger, or open a PR against your own fork for self-serve debugging. It's not needed for your following PRs. |
Ok looking better now. At least 2/3 smoke tests fail for the right reason now :) I'm afraid i wont be of much help for a fix. Rust is too unfamiliar for me. I was struggeling to set up some sort of unit/int test. I hope this smoke testcase is still some sort of use. |
Signed-off-by: tison <[email protected]>
I made an in-place fix. Let's see. You can test it locally with |
sweet! problem solved! Thanks! |
Thanks for your contribution! |
@tisonkun thanks for your support! Any idea when this is deployed to the next release? |
It's Chinese New Year this week and the next. I may schedule a release after this festival period. Feel free to ping me after that if I don't cut one. |
Thanks for the fast response. Happy Chinese New Year celebration. |
@Lorilatschki today I woke up early and finish the release, lol. It's now available as 6.0.0. You can check the CHANGELOG for other changes alongside. |
This closes #165