🐛 Address required status bug #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibolton336
force-pushed
the
address-status-issue
branch
from
07f865f to
fc6c538
Compare
ibolton336
added
the
cherry-pick/release-0.3
Signed-off-by: Ian Bolton <[email protected]>
ibolton336
force-pushed
the
address-status-issue
branch
from
7c2888d to
8c94ee8
Compare
rszwajko
approved these changes
Apr 12, 2024
sjd78
reviewed
Apr 12, 2024
Comment on lines
+94
to
+115
| rest.get("/hub/assessments", (req, res, ctx) => { | ||
| return res( | ||
| ctx.json([ | ||
| createMockAssessment({ | ||
| id: 1, | ||
| application: { id: 1, name: "app1" }, | ||
| questionnaire: { id: 1, name: "questionnaire1" }, | ||
| status: "started", | ||
| required: false, | ||
| sections: [], | ||
| }), | ||
| createMockAssessment({ | ||
| id: 2, | ||
| application: { id: 1, name: "app1" }, | ||
| questionnaire: { id: 2, name: "questionnaire2" }, | ||
| status: "complete", | ||
| required: false, | ||
| sections: [], | ||
| }), | ||
| ]) | ||
| ); | ||
| }) |
There was a problem hiding this comment.
Having the second set of handlers is a bit confusing.
I suggest just doing a use once kind of setup so it is more obvious that the data will change on the second request.
This may work (not tested):
rest.get("/hub/assessments", (req, res, ctx) => {
return res.once(
// first json
);
})
rest.get("/hub/assessments", (req, res, ctx) => {
return res(
// json for the rest of the time
);
})See: https://v1.mswjs.io/docs/api/setup-server/use#one-time-override
There was a problem hiding this comment.
Or I just found you can use a generator function in this case -- way cooler:
mswjs/msw#1117 (reply in thread)
It points at this bit of code for more examples: https://github.com/mswjs/msw/blob/6990c3a57a1f515fe977c2eaa7741005b885b8af/test/rest-api/generator.mocks.ts#L4
//cc @rszwajko
github-actions bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
Resolves https://issues.redhat.com/browse/MTA-2505 - Adds additional unit test coverage Signed-off-by: Ian Bolton <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
sjd78
pushed a commit
that referenced
this pull request
Apr 15, 2024
Resolves https://issues.redhat.com/browse/MTA-2505 - Adds additional unit test coverage Backport-of: #1843 Signed-off-by: Ian Bolton <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://issues.redhat.com/browse/MTA-2505