Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Refactor FilterSelectOptionProps (#1802) #1833

Conversation

ibolton336
Copy link
Member

Key points:

  1. do not extend PF SelectOptionProps interface - this allows to add
    custom props to the interface and provides better control what prop
    are forwarded to SelectOption
  2. remove key prop as it's a special prop used internally by React
  3. use value prop according to PF documentation - effectively replace
    previously used key prop
  4. add label prop - to be used as human friendly representation of the
    value
  5. add groupLabel prop
  6. add chipLabel prop - for cases where it differs from the label prop
    (main use case are tag items)

@ibolton336 ibolton336 force-pushed the bp-d84d1764029e4f935f2080bab44691a3a575f2f4 branch from 7d3ec47 to 2d6e812 Compare April 9, 2024 18:29
@ibolton336 ibolton336 force-pushed the bp-d84d1764029e4f935f2080bab44691a3a575f2f4 branch from 2d6e812 to c7ca26b Compare April 9, 2024 18:29
@ibolton336 ibolton336 changed the title 🌱 Refactor FilterSelectOptionProps (https://github.com/konveyor/tackle2-ui/pull/1802) 🌱 Refactor FilterSelectOptionProps (https://github.com/konveyor/tackle2-ui/pull/1802) Apr 9, 2024
@ibolton336 ibolton336 merged commit 57f41f9 into konveyor:release-0.3 Apr 9, 2024
4 of 5 checks passed
@sjd78 sjd78 changed the title 🌱 Refactor FilterSelectOptionProps (https://github.com/konveyor/tackle2-ui/pull/1802) 🌱 Refactor FilterSelectOptionProps (#1802) Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants