🐛 Add provider to custom target form #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibolton336
force-pushed
the
custom-targets-bug
branch
from
ed54045 to
a23c057
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1516 +/- ##
=======================================
Coverage 40.70% 40.70%
=======================================
Files 145 145
Lines 4589 4589
Branches 1076 1076
=======================================
Hits 1868 1868
Misses 2707 2707
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
sjd78
reviewed
Nov 7, 2023
client/src/app/pages/migration-targets/components/custom-target-form.tsx
Outdated
Show resolved
Hide resolved
client/src/app/pages/migration-targets/components/custom-target-form.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: ibolton336 <[email protected]>
ibolton336
force-pushed
the
custom-targets-bug
branch
from
c47b95e to
fdb9997
Compare
|
And the solution is to just show the selected provider type from the targets page right? We're not allowing a change in the provider type on this form. |
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://issues.redhat.com/browse/MTA-1627 as discussed in the UXD call 11-7-23
