Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add app detail to drawer #1505

Merged
merged 3 commits into from
Nov 2, 2023
Merged

✨ Add app detail to drawer #1505

merged 3 commits into from
Nov 2, 2023

Conversation

ibolton336
Copy link
Member

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9eb3dbd) 40.60% compared to head (f22f1ac) 40.60%.
Report is 2 commits behind head on main.

❗ Current head f22f1ac differs from pull request most recent head 2f21a31. Consider uploading reports for the commit 2f21a31 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1505   +/-   ##
=======================================
  Coverage   40.60%   40.60%           
=======================================
  Files         145      145           
  Lines        4586     4586           
  Branches     1074     1106   +32     
=======================================
  Hits         1862     1862           
+ Misses       2712     2627   -85     
- Partials       12       97   +85     
Flag Coverage Δ
client 40.60% <ø> (ø)
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 34 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ibolton336 ibolton336 force-pushed the mta-1538 branch 2 times, most recently from e3fbb7c to f22f1ac Compare November 1, 2023 19:27
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the one questions about if effort can be undefined

Signed-off-by: ibolton336 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants