Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add provider dropdown for targets #1500

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Conversation

ibolton336
Copy link
Member

Signed-off-by: ibolton336 <[email protected]>
Signed-off-by: ibolton336 <[email protected]>
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (a797572) 40.60% compared to head (dba2edc) 40.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1500      +/-   ##
==========================================
- Coverage   40.60%   40.58%   -0.02%     
==========================================
  Files         145      145              
  Lines        4586     4590       +4     
  Branches     1074     1074              
==========================================
+ Hits         1862     1863       +1     
- Misses       2712     2715       +3     
  Partials       12       12              
Flag Coverage Δ
client 40.58% <33.33%> (-0.02%) ⬇️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/src/app/api/models.ts 100.00% <ø> (ø)
...pages/applications/analysis-wizard/set-targets.tsx 10.34% <33.33%> (+0.70%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as the user does not need to see targets across all languages at the same time.

@sjd78 sjd78 self-requested a review November 2, 2023 17:56
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM as long as a "Show Targets For All Languages" option is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants