🐛 Add application risk to assessment drawer #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ibolton336 <[email protected]>
ibolton336
force-pushed
the
update-assessment-drawer
branch
from
5bfb523 to
32d426a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1488 +/- ##
=======================================
Coverage 40.31% 40.31%
=======================================
Files 143 143
Lines 4524 4524
Branches 1108 1108
=======================================
Hits 1824 1824
Misses 2603 2603
Partials 97 97
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
sjd78
requested changes
Oct 25, 2023
| @@ -36,5 +36,5 @@ export const ApplicationRisk: React.FC<IApplicationRiskProps> = ({ | |||
| ); | |||
| } | |||
|
|
|||
| return <RiskLabel risk={assessments[0].risk || "unknown"} />; | |||
| return <RiskLabel risk={application.risk || "unknown"} />; | |||
There was a problem hiding this comment.
With risk arriving on the application from hub, and only being shown from there, is any of the assessment fetching still needed? Seems like the ApplicationRisk component may not be needed any longer.
mturley
reviewed
Oct 25, 2023
Signed-off-by: ibolton336 <[email protected]>
Signed-off-by: Ian Bolton <[email protected]>
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/MTA-1504