Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix sorting on application inventory tables, misc cleanup in these tables #1396

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

mturley
Copy link
Collaborator

@mturley mturley commented Sep 25, 2023

  • The getSortValues property was missing from these two tables which turned sorting into a noop.
  • The isExpandable prop was present on the analysis table even though it is no longer expandable.
  • There was a missing empty <Th /> in each of these tables to correspond to the edit-pencil column. (perhaps hasActionsColumn is a bad idea since it makes us incorrectly assume the column counts will always be aligned for us?)

@ibolton336
Copy link
Member

(perhaps hasActionsColumn is a bad idea since it makes us incorrectly assume the column counts will always be aligned for us?)

@mturley The reason I ended up using two actions columns is because I couldn't get the spacing to play nice with two icons in one actions column. Maybe somebody else would have more luck who has more experience with PF css overrides.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (70c029b) 41.34% compared to head (2410175) 41.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1396   +/-   ##
=======================================
  Coverage   41.34%   41.34%           
=======================================
  Files         138      138           
  Lines        4334     4334           
  Branches     1039     1039           
=======================================
  Hits         1792     1792           
  Misses       2454     2454           
  Partials       88       88           
Flag Coverage Δ
client 41.34% <ø> (ø)
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants