🐛 Fix sorting on application inventory tables, misc cleanup in these tables #1396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getSortValues
property was missing from these two tables which turned sorting into a noop.isExpandable
prop was present on the analysis table even though it is no longer expandable.<Th />
in each of these tables to correspond to the edit-pencil column. (perhapshasActionsColumn
is a bad idea since it makes us incorrectly assume the column counts will always be aligned for us?)