Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Remove redundant targets from defaults list and sort targets #1354

Merged
merged 1 commit into from
Sep 15, 2023
Merged

🐛 Remove redundant targets from defaults list and sort targets #1354

merged 1 commit into from
Sep 15, 2023

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Sep 13, 2023

  • Remove from "default targets" the targets already stored in the hub.
  • Sort all targets by label so they appear alphabetically in the select option (especially important because the whole is a concatenation of the default and hub targets, which is why this wasn't obvious when looking at the list from dropdown).
  • Use proper name for defaults targets. It makes them more consistent with struct of hub stored targets. Although those names (for the default targets only) seems to not be used anywhere in the UI. And easier if down the track we merge both (defaults and hub targets) in the back-end.

Resolves https://issues.redhat.com/browse/MTA-1258

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 16.66% and project coverage change: -0.08% ⚠️

Comparison is base (874a7c8) 41.50% compared to head (bbe7867) 41.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1354      +/-   ##
==========================================
- Coverage   41.50%   41.43%   -0.08%     
==========================================
  Files         137      137              
  Lines        4281     4279       -2     
  Branches     1027     1026       -1     
==========================================
- Hits         1777     1773       -4     
- Misses       2417     2418       +1     
- Partials       87       88       +1     
Flag Coverage Δ
client 41.43% <16.66%> (-0.08%) ⬇️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...pages/applications/analysis-wizard/set-options.tsx 15.68% <0.00%> (-0.65%) ⬇️
client/src/app/data/targets.ts 100.00% <100.00%> (+28.57%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gildub gildub self-assigned this Sep 14, 2023
@gildub gildub changed the title 🐛 Remove redundant targets from defaults; Sort them 🐛 Remove redundant targets from defaults list and sort targets Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants