Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👻 Share assessments between app & archetypes #1348

Merged
merged 15 commits into from
Sep 14, 2023

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Sep 11, 2023

  • New component created for assessment actions row to include delete logic and clean up files.
  • Get tag create working again in preparation for auto answer by tag work integration
  • Wire up archetype crud to api
  • Move assessment code to its own page in directory structure
  • Remove deprecated bulk copy code
  • Remove assess application hook
  • Update risk code to use hub api values for risk on assessment
  • Remove deprecated rest handlers for getAssessments

@ibolton336 ibolton336 force-pushed the auto-answer-wizard-fields branch from 5f27322 to 3a3bee9 Compare September 11, 2023 22:33
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 30.37% and project coverage change: -0.91% ⚠️

Comparison is base (3ff9fe9) 42.41% compared to head (a98207b) 41.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1348      +/-   ##
==========================================
- Coverage   42.41%   41.50%   -0.91%     
==========================================
  Files         138      137       -1     
  Lines        4315     4281      -34     
  Branches     1026     1027       +1     
==========================================
- Hits         1830     1777      -53     
- Misses       2399     2417      +18     
- Partials       86       87       +1     
Flag Coverage Δ
client 41.50% <30.37%> (-0.91%) ⬇️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
client/src/app/Constants.ts 100.00% <ø> (ø)
client/src/app/api/models.ts 100.00% <ø> (ø)
...s/components/application-form/application-form.tsx 59.60% <ø> (+0.29%) ⬆️
...ents/questionnaire-form/question/question-body.tsx 83.33% <ø> (ø)
...ts/questionnaire-form/question/question-header.tsx 83.33% <ø> (ø)
...omponents/questionnaire-form/question/question.tsx 83.33% <ø> (ø)
...ep-nav-description/wizard-step-nav-description.tsx 100.00% <ø> (ø)
client/src/app/pages/assessment/form-utils.ts 100.00% <ø> (ø)
client/src/app/queries/reviews.ts 20.75% <19.51%> (-8.66%) ⬇️
client/src/app/api/rest.ts 49.71% <29.62%> (-4.39%) ⬇️
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ibolton336 ibolton336 force-pushed the auto-answer-wizard-fields branch 2 times, most recently from 64293c9 to c263258 Compare September 12, 2023 14:41
@ibolton336 ibolton336 marked this pull request as draft September 12, 2023 15:47
@ibolton336 ibolton336 force-pushed the auto-answer-wizard-fields branch 2 times, most recently from 539bf4e to 7e38051 Compare September 12, 2023 15:54
@ibolton336 ibolton336 changed the title 👻 Create new component for assessment actions row 👻 Share assessments between app & archetypes Sep 12, 2023
@ibolton336 ibolton336 marked this pull request as ready for review September 12, 2023 15:55
@ibolton336 ibolton336 force-pushed the auto-answer-wizard-fields branch from 7e38051 to 2b93ac6 Compare September 12, 2023 18:45
@ibolton336 ibolton336 marked this pull request as draft September 12, 2023 19:57
@ibolton336 ibolton336 marked this pull request as ready for review September 13, 2023 19:57
@ibolton336 ibolton336 marked this pull request as draft September 13, 2023 21:21
Copy link
Collaborator

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking real nice 😎

@ibolton336 ibolton336 marked this pull request as ready for review September 14, 2023 19:21
@ibolton336 ibolton336 force-pushed the auto-answer-wizard-fields branch from 474e3fc to 7329c68 Compare September 14, 2023 19:22
@ibolton336 ibolton336 force-pushed the auto-answer-wizard-fields branch 3 times, most recently from 10e2620 to a340d00 Compare September 14, 2023 19:39
Signed-off-by: ibolton336 <[email protected]>
@ibolton336 ibolton336 force-pushed the auto-answer-wizard-fields branch from a340d00 to a98207b Compare September 14, 2023 19:52
@ibolton336 ibolton336 merged commit 88ae668 into konveyor:main Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants