✨ Archetypes management: Add navigation and placeholder page component #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1308 +/- ##
==========================================
+ Coverage 42.54% 42.58% +0.03%
==========================================
Files 136 136
Lines 4207 4220 +13
Branches 1000 1000
==========================================
+ Hits 1790 1797 +7
- Misses 2405 2411 +6
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
sjd78
force-pushed
the
archetypes-issue1263
branch
2 times, most recently
from
ee8665a to
b6fd2f7
Compare
sjd78
requested review from
gildub,
ibolton336,
mturley,
gitdallas and
avivtur
sjd78
force-pushed
the
archetypes-issue1263
branch
from
b6fd2f7 to
8ba8e5d
Compare
sjd78
changed the title
ibolton336
reviewed
Sep 1, 2023
| comments: string; | ||
| criteriaTags: Tag[]; | ||
| archetypeTags: Tag[]; | ||
| assessmentTags?: Tag[]; |
There was a problem hiding this comment.
I think these are going to be CategorizedTag but probably TBD what that data model will look like in its final form.
There was a problem hiding this comment.
I figure there will be a bunch of those kinds of mismatches, but if we make some good guesses, we shouldn't be far off. I just named it after this mockup:
ibolton336
reviewed
Sep 1, 2023
ibolton336
requested changes
Sep 1, 2023
Closed
- Add route `/archetypes` - "Archetypes" added under "Application Inventory" - Very basic placeholder page component Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
- Display a list of archetypes - Simple column components for Tags, Maintainers, Applications - Filtering on name - Action button is in place but doesn't do anything - TODO items in sources for things that need to be added later Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
force-pushed
the
archetypes-issue1263
branch
from
8ba8e5d to
0c1db05
Compare
Changes made. I also pulled the individual table column components out into their own files. |
mturley
approved these changes
Sep 1, 2023
Signed-off-by: Scott J Dickerson <[email protected]>
ibolton336
approved these changes
Sep 1, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work done:
/archetypesResolves #1263
Full function archetypes table will be done under #1264
Full function archetypes add/edit form will be done under #1265
Base display, with mock/stub data from MSW:
