-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Convert assessment table to new table & begin assessment flow changes #1294
Conversation
cd8e246
to
7746f90
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1294 +/- ##
=======================================
Coverage 42.96% 42.97%
=======================================
Files 144 145 +1
Lines 4317 4330 +13
Branches 999 999
=======================================
+ Hits 1855 1861 +6
- Misses 2381 2457 +76
+ Partials 81 12 -69
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
4e356ab
to
6ca3661
Compare
...c/app/pages/applications/applications-table-assessment/old-applications-table-assessment.tsx
Outdated
Show resolved
Hide resolved
Looks like there are some test failures due to mock imports |
917b118
to
0fea180
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is real good stuff @ibolton336 ! I just have a couple of small things we can improve.
...t/src/app/pages/applications/applications-table-assessment/applications-table-assessment.tsx
Outdated
Show resolved
Hide resolved
...t/src/app/pages/applications/applications-table-assessment/applications-table-assessment.tsx
Outdated
Show resolved
Hide resolved
...t/src/app/pages/applications/applications-table-assessment/applications-table-assessment.tsx
Outdated
Show resolved
Hide resolved
...t/src/app/pages/applications/applications-table-assessment/applications-table-assessment.tsx
Outdated
Show resolved
Hide resolved
<NoDataEmptyState | ||
title={t("composed.noDataStateTitle", { | ||
what: t("terms.applications").toLowerCase(), | ||
})} | ||
description={t("composed.noDataStateBody", { | ||
what: t("terms.application").toLowerCase(), | ||
})} | ||
/> | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason I am seeing this empty state on first page load just because the apps haven't been loaded yet. I'm surprised because you do already handle the loading case above with <ConditionalRender>
, so there's something funky going on there.
Edit: Hm, it's also a problem on main actually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing the empty state flash briefly before rendering the table items after removing the if statement mentioned above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm ok. Maybe we address that as a followup issue? However you want to handle that is fine with me
...t/src/app/pages/applications/applications-table-assessment/applications-table-assessment.tsx
Outdated
Show resolved
Hide resolved
...t/src/app/pages/applications/applications-table-assessment/applications-table-assessment.tsx
Outdated
Show resolved
Hide resolved
...t/src/app/pages/applications/applications-table-assessment/applications-table-assessment.tsx
Outdated
Show resolved
Hide resolved
client/src/app/pages/applications/assessment-actions/components/assessment-actions-table.tsx
Outdated
Show resolved
Hide resolved
...t/src/app/pages/applications/applications-table-assessment/applications-table-assessment.tsx
Outdated
Show resolved
Hide resolved
...t/src/app/pages/applications/applications-table-assessment/applications-table-assessment.tsx
Outdated
Show resolved
Hide resolved
...t/src/app/pages/applications/applications-table-assessment/applications-table-assessment.tsx
Outdated
Show resolved
Hide resolved
Update questionnaire model to match hub proposal Start on Assessment Actions page Restore drawer click bug fix Add empty state for assessments Update the dropdown within the app toolbar to remove old options Fix kebab toggle styles for PF5 Add back in review functionality Add pending confirmation dialog for assessment action Setup mock data for assessment actions Add actions table for assessment actions page Signed-off-by: ibolton336 <[email protected]>
65d949d
to
e4ad6a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…es (konveyor#1294) - Update questionnaire TS model to match hub proposal ``` type Questionnaire struct { Resource Name string Description string Revision uint Required bool Sections []Section Thresholds Thresholds RiskMessages RiskMessages } type Assessment struct { Resource Application *Ref Archetype *Ref Questionnaire *Ref Sections []Section } ``` - Convert assessment table to use new table format - No longer allow bulk assessment on assessment page top level toolbar as this functionality is moving to Archetypes. Review & assessment buttons moved to dropdown kebabs on the row level. - Assessment Actions page with application level questionnaires/assessments listed. TODO: [Add dynamic actions button](konveyor#1299) based on current assessment status - Adds placeholder assessment modal when assessment action is triggered from the assessment table row. TODO: [Add existing archetype check](konveyor#1298) - TODO: [View assessments page for existing assessments](konveyor#1301) for viewing existing assessments when clicking assess on an application that already has an associated completed assessment - TODO: [Convert assessment wizard ](konveyor#1306) -TODO: Fix empty state initial render konveyor#1311 Signed-off-by: ibolton336 <[email protected]>
-TODO: Fix empty state initial render Flashing empty state on applications table #1311